fix: remove temporary files when multiple write operations conflict #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/remove-temporary-files-put-many
branch
3 times, most recently
from
7ba8294
to
69cc2bc
Compare
willscott
approved these changes
Apr 10, 2020
When multiple write operations conflict, we: 1. Try them in-order till one succeeds. 2. After the fact, re-order them such that the pending operations "happen" after the one that succeeds. 3. Return "success" for all the pending write operations for that key. This is acceptable because we're claiming that the operation that _actually_ succeeded happened "last" so it would have clobbered the other operations. However, in the case of put, we still need to remove the temporary file that we didn't end up moving into place.
Stebalien
force-pushed
the
fix/remove-temporary-files-put-many
branch
from
69cc2bc
to
579b3c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple write operations conflict, we:
However, in the case of put, we still need to remove the temporary file that we didn't end up moving into place.