cleanup putMany implementation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Apr 13, 2020
| // signify removed | ||
| ops[fi] = 2 | ||
| } else if !done { | ||
| _ = os.Remove(pop.file.Name()) |
There was a problem hiding this comment.
I've convinced myself this works, but there are two things suboptimal we might want to make better:
- The distinction between
pop.pathandpop.file.Name()is not well named - which is previous vs new location? - We're accessing a method (
.Name()) after.Close()ing files. That's relying on the internal behavior to not clear all state when closing the handle, which an implementation would be within its rights to do.
willscott
approved these changes
Apr 13, 2020
* Use a map for dirsToSync to avoid syncing the same dir multiple times. * Keep track of files in a slice, and use offsets into the slice to keep track of which ones have been closed/removed. Also, record the fact that we've created a temporary file _before_ we try to write to it, in case the write fails. That way, we'll try to remove it when we abort.
Stebalien
force-pushed
the
feat/clean-remove
branch
from
4d604ee
to
bc42aaa
Compare
|
@willscott good point. I've addressed your feedback. |
willscott
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of which ones have been closed/removed.
Also, record the fact that we've created a temporary file before we try to write to it, in case the write fails. That way, we'll try to remove it when we abort.