Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move retries lower and retry rename ops #82

Merged
merged 4 commits into from
Apr 17, 2020
Merged

move retries lower and retry rename ops #82

merged 4 commits into from
Apr 17, 2020

Commits on Apr 17, 2020

  1. feat: move retries lower 

    Instead or retrying the whole operation, retry the specific parts that can fail.

I believe this also fixes cases where we might end up with a retry loop within a
retry loop? I'm not sure.
    @Stebalien
    Stebalien committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    9b83d06 View commit details
    Browse the repository at this point in the history

  2. feat: retry renames 

    Retry renames when the error wasn't due to a file not existing. This case can
come up on windows when some other process opens the file for reading while
we're trying to rename it.
    @Stebalien
    Stebalien committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    ea3fd05 View commit details
    Browse the repository at this point in the history

  3. fix: simplify 

    Co-Authored-By: Will <will.scott@protocol.ai>
    @Stebalien @willscott
    Stebalien and willscott committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    d174dc3 View commit details
    Browse the repository at this point in the history

  4. fix: retry deletes

    @Stebalien
    Stebalien committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    c5ecd44 View commit details
    Browse the repository at this point in the history