Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent closing concurrently with other operations. #42

Merged
merged 1 commit into from Feb 25, 2020
Merged

prevent closing concurrently with other operations. #42

merged 1 commit into from Feb 25, 2020

Conversation

willscott
Copy link
Contributor

Add a sync.RWMutex protecting the Close operation.
Follows the same pattern as in go-ds-badger.
Address #29 / ipfs/kubo#6880

aschmahmann
aschmahmann requested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Left a couple comments to look into.

datastore.go Outdated Show resolved Hide resolved
ds_test.go Show resolved Hide resolved
aschmahmann
aschmahmann approved these changes Feb 21, 2020
View reviewed changes
datastore.go Outdated Show resolved Hide resolved
@willscott willscott marked this pull request as ready for review February 21, 2020 21:57
Stebalien
Stebalien requested changes Feb 24, 2020
View reviewed changes
datastore.go Show resolved Hide resolved
datastore.go Outdated Show resolved Hide resolved
datastore.go Outdated Show resolved Hide resolved
Stebalien
Stebalien approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one thing to check. Merge when you've either locked on i.Release() or have confirmed that this isn't an issue (and left a comment in the code?).

datastore.go Show resolved Hide resolved
Stebalien
Stebalien approved these changes Feb 25, 2020
View reviewed changes
datastore.go Outdated Show resolved Hide resolved
@willscott
prevent closing concurrently with other operations.
5d92b4d 
Add a `sync.RWMutex` protecting the Close operation.
Follows the same pattern as in go-ds-badger.
Address #29 / ipfs/kubo#6880
@willscott willscott merged commit 8e15c83 into master Feb 25, 2020
@willscott willscott deleted the bug/race-close branch February 25, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willscott @Stebalien @aschmahmann