Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoNotSend extension should NOT send ALL cids receieved #203

Closed
aarshkshah1992 opened this issue Aug 19, 2021 · 3 comments
Closed

DoNotSend extension should NOT send ALL cids receieved #203

aarshkshah1992 opened this issue Aug 19, 2021 · 3 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Aug 19, 2021

To support transfer resumption, a Graphsync requestor sends a DoNotSendCids message to the responder with ALL the CIDs received so far. This solution does NOT scale as sending ALL cids recieved for large data transfers causes the message size to exceed the message size limits set by the Graphsync protocol.

We need to redesign the DoNotSendCIds extension.

@aarshkshah1992 aarshkshah1992 added the need/triage Needs initial labeling and prioritization label Aug 19, 2021
@welcome
Copy link

welcome bot commented Aug 19, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@aarshkshah1992
Copy link
Contributor Author

@whyrusleeping @raulk - If you guys wanna subscribe to this.

@aarshkshah1992
Copy link
Contributor Author

Moving this to go-data-transfer as @hannahhoward has a point that this needs to be fixed there as the DoNotSendCIds has uses cases beyond transfer resumption as well and does it's job correctly.

marten-seemann pushed a commit that referenced this issue Mar 2, 2023
* refactor: simplify graphsync transport

* feat: add more logging to graphsync transport

* refactor: keep gs req fields in one struct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant