Add cancel request and wait function #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix hang in code due to potential race, mark this code in need of replacement
add a cancel request that waits for the request to fully complete. add test that verifies no race.
rename RequestContextCancelledErr to reflect reason for err
Yes I think that's a good idea 👍 |
add a context that can timeout a cancel request if it doesn't finish in a set time
hannahhoward
changed the title
|
@dirkmc added :) |
|
Great, thanks 👍 Looks like there are still a couple of |
dirkmc
reviewed
Aug 3, 2021
masih
approved these changes
Aug 3, 2021
hannahhoward
force-pushed
the
feat/cancel-request-and-wait
branch
from
f7bf0a5
to
4a7ecf8
Compare
dirkmc
approved these changes
Aug 4, 2021
hannahhoward
added a commit
that referenced
this pull request
Aug 5, 2021
* feat: fire network error when network disconnects during request (#164) * release: 0.6.1 * Better logging for Graphsync traversal (#167) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <dirkmdev@gmail.com> * add debug logs * add debug logs Co-authored-by: dirkmc <dirkmdev@gmail.com> * release: v0.6.2 (#168) * Fix/log blockstore reads (#169) * log gs traversal * Apply suggestions from code review Co-authored-by: dirkmc <dirkmdev@gmail.com> * add debug logs * fixed logging * Apply suggestions from code review Co-authored-by: dirkmc <dirkmdev@gmail.com> * fixed error Co-authored-by: dirkmc <dirkmdev@gmail.com> * release: v0.6.3 (#170) * request queued hook * test request queued hook * release: v0.6.4 * Resolve 175 race condition, no change to hook timing (#178) * feat(requestmanager): add request timing (#181) * Add cancel request and wait function (#185) * fix(responsemanager): fix error codes (#182) enforce much tighter consistency with graphsync spec in usage of error codes * refactor: replace particular request not found errors with public error (#188) * release: 0.6.8 Co-authored-by: dirkmc <dirkmdev@gmail.com> Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* fix: dont double count data sent * fix: stricter asserts in channels tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Add an imperative method that cancels a graphsync request and does not return until no further blocks can load and the request is completely cleaned up
Implementation
For Discussion
Would it make sense to have CancelRequest take a context, where if that context expired the routine would return even if the request had not signaled it was done (just in case?)
Fixes #184