Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shutdown queue on publish error if not done #412

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: shutdown queue on publish error if not done #412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76709ee
fix: shutdown queue on publish error if not done
jacobheun Mar 7, 2023
7aa9006
fix: use the more targeted shutdown
jacobheun Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion messagequeue/messagequeue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,13 @@ func (mq *MessageQueue) sendMessage() {
log.Infof("cant open message sender to peer %s: %s", mq.p, err)
// TODO: cant connect, what now?
mq.publishError(metadata, fmt.Errorf("cant open message sender to peer %s: %w", mq.p, err))
return
select {
case <-mq.done:
return
default:
mq.Shutdown()
return
}
}

for i := 0; i < mq.maxRetries; i++ { // try to send this message until we fail.
Expand Down