Revert "Bring changes from #412" #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a5f79a5.
gammazero
approved these changes
Apr 13, 2023
|
Close this in favor of #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This commit is the source of the problems in go-data-transfer tests. ( filecoin-project/go-data-transfer#373, filecoin-project/go-data-transfer#374 )
I'm not sure I want to merge this, as #412 also fixes a memory leak. The short version of the problem is: 412 contains a pretty serious problem where it shuts down the message queue, but fails to tell the peer manager to remove it, so if a reconnect happens, the peer manager may never realize the queue shutdown, and send messages to a shutdown queue. This is bad cause I think theoretically Boost's version can break a node-disconnect-reconnect from ever sending messages.
cc: @jacobheun who wrote original PR.