Add DAG Protobuf Support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
So, having to link-in the DagPB IPLD codec this way smells but fixing it now would unnecessarily block this.
@warpfork and @hannahhoward, could you work together to figure out a clean way to avid this? Maybe:
- Have a registry of node builders?
- Have codecs specify supported/default node builders?
- Create an even more basic default node builder such that implementing DagPB with this node builder isn't painful?
I'm not familiar enough with the architecture to make any specific suggestions.
hannahhoward
force-pushed
the
feat/response-hooks
branch
from
ebbe656
to
dffc8e6
Compare
hannahhoward
force-pushed
the
feat/dag-protobuf
branch
from
854c867
to
7f06421
Compare
Incorporate go-ipld-prime-proto and write test to verify that graphsync works with it
hannahhoward
force-pushed
the
feat/dag-protobuf
branch
from
7f06421
to
e72f36a
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
chore(deps): update graphsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to auto closed pull request #46 -- now rebased on the feat/response hooks -- please see that PR for previous discussion