Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

initial testing setup #14

Merged
merged 4 commits into from
Sep 23, 2015
Merged

initial testing setup #14

merged 4 commits into from
Sep 23, 2015

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Sep 15, 2015

How do you guys feel about this testing setup?

Using the example data feels a bit wonky. For Travis we should probably use a specific version of the docker image then.

@jbenet i couldn't enable travis for this repo because i don't have admin rights.

@cryptix cryptix mentioned this pull request Sep 15, 2015
Merged
@cryptix
Copy link
Contributor Author

cryptix commented Sep 15, 2015

@jbenet @whyrusleeping rebased and fixed :) 👍

@whyrusleeping
Copy link
Member

awesome! let me enable travis real quick...

@jbenet
Copy link
Member

jbenet commented Sep 15, 2015

travis enabled

@jbenet
Copy link
Member

jbenet commented Sep 15, 2015

Will probably need to repush to trigger it

jbenet
jbenet reviewed Sep 15, 2015
View reviewed changes
.travis.yml
before_install:
- docker pull jbenet/go-ipfs:latest
- mkdir /tmp/ipfs && chmod 0777 /tmp/ipfs
- docker run -d -v /tmp/ipfs:/data/ipfs -p 8080:8080 -p 4001:4001 -p 5001:5001 jbenet/go-ipfs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, this works? nice!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I use it in my git-remote-ipfs tests :)

@cryptix
Copy link
Contributor Author

cryptix commented Sep 20, 2015

@jbenet ping :)

@jbenet
Copy link
Member

jbenet commented Sep 23, 2015

LGTM! 👍

jbenet added a commit that referenced this pull request Sep 23, 2015
@jbenet
Merge pull request #14 from ipfs/testing
92bb139 
initial testing setup
@jbenet jbenet merged commit 92bb139 into master Sep 23, 2015
@jbenet jbenet deleted the testing branch September 23, 2015 13:07
@jbenet
Copy link
Member

jbenet commented Sep 23, 2015

somehow the merge testing failed: https://travis-ci.org/ipfs/go-ipfs-api/builds/81770162

@cryptix
Copy link
Contributor Author

cryptix commented Sep 23, 2015

somehow the merge testing failed: https://travis-ci.org/ipfs/go-ipfs-api/builds/81770162

Hrm.. they did pass before... Error response from daemon: Cannot start container ....: iptables failed: iptables --wait -t filter -A DOCKER ! -i docker0 -o docker0 -p tcp -d 172.17.0.1 --dport 8080 -j ACCEPT: iptables: No chain/target/match by that name. sadly isn't code related at all. I've seen it a couple of times but usually re-run fixed it after the 2nd try, now I can't get it to pass at all.. I fear it's influenced by load... :-/

@cryptix
Copy link
Contributor Author

cryptix commented Sep 23, 2015

Related: travis-ci/travis-ci#4778

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptix @whyrusleeping @jbenet