-
Notifications
You must be signed in to change notification settings - Fork 36
Allow using a NewWriteThrough() blockstore. #112
Conversation
Similar to blockservice.NewWriteThrough(). Currently the default blockstore trades read amplification for every write. While this is fine in cases where writes are very expensive and the datastore offers a quick Has() method, it is not always the case. Some datastore backends may be better off just getting all the writes no matter what. At least I would like to try it out.
Suggested version: Changes in diff --git a/go.mod b/go.mod
index 6161e15..5fe47bc 100644
--- a/go.mod
+++ b/go.mod
@@ -15,4 +15,25 @@ require (
go.uber.org/atomic v1.6.0
)
-go 1.16
+require (
+ github.com/gogo/protobuf v1.2.1 // indirect
+ github.com/google/uuid v1.1.1 // indirect
+ github.com/jbenet/goprocess v0.1.4 // indirect
+ github.com/mattn/go-colorable v0.1.1 // indirect
+ github.com/mattn/go-isatty v0.0.5 // indirect
+ github.com/minio/blake2b-simd v0.0.0-20160723061019-3f5f724cb5b1 // indirect
+ github.com/minio/sha256-simd v0.1.1-0.20190913151208-6de447530771 // indirect
+ github.com/mr-tron/base58 v1.1.3 // indirect
+ github.com/multiformats/go-base32 v0.0.3 // indirect
+ github.com/multiformats/go-base36 v0.1.0 // indirect
+ github.com/multiformats/go-multibase v0.0.3 // indirect
+ github.com/multiformats/go-varint v0.0.5 // indirect
+ github.com/opentracing/opentracing-go v1.0.2 // indirect
+ github.com/spaolacci/murmur3 v1.1.0 // indirect
+ github.com/whyrusleeping/go-logging v0.0.0-20170515211332-0457bb6b88fc // indirect
+ golang.org/x/crypto v0.0.0-20190611184440-5c40567a22f8 // indirect
+ golang.org/x/net v0.0.0-20190620200207-3b0461eec859 // indirect
+ golang.org/x/sys v0.0.0-20190412213103-97732733099d // indirect
+)
+
+go 1.19
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
@hsanjuan LGTM Thx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
Similar to blockservice.NewWriteThrough().
Currently the default blockstore trades read amplification for every write. While this is fine in cases where writes are very expensive and the datastore offers a quick Has() method, it is not always the case.
Some datastore backends may be better off just getting all the writes no matter what. At least I would like to try it out.