fix: don't return an empty block at the end #22

Stebalien · 2020-03-26T02:18:52Z

And make the buzhash test fuzz for issues like this.

ribasushi

Tested against go-ipfs, all resulting pathological cases result in correctly cat-able streams. Thanks for picking this up.

Kubuxu

thanks, and sorry for not finding it

…y-block fix: don't return an empty block at the end This commit was moved from ipfs/go-ipfs-chunker@0311814

Stebalien added 2 commits March 25, 2020 19:14

fix: don't return an empty block at the end

ca4d27b

test(buzhash): fuzz

b4e4e73

Stebalien requested review from Kubuxu and ribasushi March 26, 2020 02:19

ribasushi approved these changes Mar 26, 2020

View reviewed changes

Kubuxu approved these changes Mar 26, 2020

View reviewed changes

ribasushi merged commit 0311814 into master Mar 26, 2020

ribasushi deleted the fix/buzhash-empty-block branch March 26, 2020 20:40

Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023

Merge pull request ipfs/go-ipfs-chunker#22 from ipfs/fix/buzhash-empt…

77ec5cd

…y-block fix: don't return an empty block at the end This commit was moved from ipfs/go-ipfs-chunker@0311814

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: don't return an empty block at the end #22

fix: don't return an empty block at the end #22

Stebalien commented Mar 26, 2020

ribasushi left a comment

Kubuxu left a comment

fix: don't return an empty block at the end #22

fix: don't return an empty block at the end #22

Conversation

Stebalien commented Mar 26, 2020

ribasushi left a comment

Choose a reason for hiding this comment

Kubuxu left a comment

Choose a reason for hiding this comment