Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: How to handle CIDv0 as we migrate to CIDV1 #5291

Open
2 of 3 tasks
kevina opened this issue Jul 27, 2018 · 0 comments
Open
2 of 3 tasks

RFC: How to handle CIDv0 as we migrate to CIDV1 #5291

kevina opened this issue Jul 27, 2018 · 0 comments
Labels
topic/cidv1b32 Topic cidv1b32

Comments

@kevina
Copy link
Contributor

kevina commented Jul 27, 2018

How should we handle existing CIDv0 as we migrate to CIDv1?

Some issues:

  • Should pins be normalized to CIDv1
  • Should we automatically convert CIDv0 to CIDv1 is display
    • @kevina think this might be a good idea in higher level commands such as ipfs add and ipfs ls, but lower level command such as ipfs dag and ipfs object CIDs should be left alone. In any case this should be controllable be a command line flag. @Stebalien also things so so I am assuming this is a yes.
  • Should ipfs add default to full CIDv1 when raw leaves or not used or should it keep the internal links as CidV0 and just return a CidV1 for the root. The reason we might want to do this is because we put a lot of weight on keeping hashes the same.
    • The concurrences seams to be that we should keep internal links using CidV0 as default, at least for now

@whyrusleeping @diasdavid I know you both had thoughts on this. When you get a chance could you write down what you had in mind in the commends so we are all on the same page.

@Stebalien, others, general feedback is welcome.

@kevina kevina added the topic/cidv1b32 Topic cidv1b32 label Jul 27, 2018
@kevina kevina changed the title How to handle the displaying of CIDv0 How to handle CIDv0 as we migrate to CIDV1 Aug 13, 2018
@kevina kevina changed the title How to handle CIDv0 as we migrate to CIDV1 RFC: How to handle CIDv0 as we migrate to CIDV1 Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/cidv1b32 Topic cidv1b32
Projects
None yet
Development

No branches or pull requests

1 participant