Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade quic-go to v0.26.0 to support building with Go 1.18 #8819

Closed
3 tasks done
makew0rld opened this issue Mar 23, 2022 · 10 comments
Closed
3 tasks done

Upgrade quic-go to v0.26.0 to support building with Go 1.18 #8819

makew0rld opened this issue Mar 23, 2022 · 10 comments
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met

Comments

@makew0rld
Copy link
Contributor

makew0rld commented Mar 23, 2022 •
edited

Checklist

Installation method

built from source

Version

I am using IPFS (v0.12.0) as a library, but the problem remains when building the latest commit or release from source.

Config

Not relevant to the issue.

Description

When building go-ipfs, I get this error:

# github.com/lucas-clemente/quic-go/internal/qtls
../../../../pkg/mod/github.com/lucas-clemente/quic-go@v0.24.0/internal/qtls/go118.go:6:13: cannot use "quic-go doesn't build on Go 1.18 yet." (untyped string constant) as int value in variable declaration

This is because I'm building with Go 1.18, and v0.24.0 of quic-go doesn't support Go 1.18. v0.26.0, released yesterday, now supports Go 1.18. It would be great if go-ipfs could upgrade this dependency to support the latest Go version.

I understand quic-go is not a direct dependency of go-ipfs, so feel free to transfer the issue. I just wanted to file it here since my problem is when trying to build go-ipfs.
@makew0rld makew0rld added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Mar 23, 2022
@dvergeylen
Copy link

dvergeylen commented Mar 24, 2022 •
edited

As a temporary workaround, one may want to upgrade the dependency himself:

go get github.com/lucas-clemente/quic-go@v0.26.0

make build then compiles as expected.

@makew0rld
Copy link
Contributor Author

Thanks for the tip. I was worried about messing things up by doing that upgrade, since the libraries using quic-go weren't written with this latest version in mind. For now I just switched back to Go 1.17.

@aschmahmann
Copy link
Contributor

This will likely not happen until #8680 has landed.

@aschmahmann aschmahmann added P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met and removed need/triage Needs initial labeling and prioritization labels Mar 24, 2022
@marten-seemann
Copy link
Member

We'll be releasing go-libp2p v0.19.0 very soon (tracking issue: libp2p/go-libp2p#1298), which will include a newer version of quic-go that builds with Go 1.18.

@RobotSail
Copy link

@marten-seemann Any ETA on when that'll land?
We're currently setting up a process to have automated IPFS binary builds for COPR so that RHEL users could access updated builds and this is blocking us as well

@RubenKelevra
Copy link
Contributor

We'll be releasing go-libp2p v0.19.0 very soon (tracking issue: libp2p/go-libp2p#1298), which will include a newer version of quic-go that builds with Go 1.18.

Would be nice if this could be split off and just this fix could be added as there seems to be no downside to using the newer QUIC version (as explained in a previous comment by @dvergeylen), or is there?

@mrd0ll4r mrd0ll4r mentioned this issue Apr 6, 2022
Merged
@MrAdityaAlok MrAdityaAlok mentioned this issue Apr 9, 2022
Merged
@NatoBoram
Copy link
Contributor

It should work at the moment

go-ipfs version: 0.13.0-dev-63b002566
Repo version: 12
System version: amd64/linux
Golang version: go1.18.1

amuramatsu pushed a commit to amuramatsu/termux-packages that referenced this issue Apr 15, 2022
@MrAdityaAlok @amuramatsu
chore(ipfs): update to 1.12.2
8dd36bc 
- manually update `quic-go` library until
  ipfs/kubo#8819 is resolved.

- remove already defined vars

Signed-off-by: Aditya Alok <dev.aditya.alok@gmail.com>
@lidel
Copy link
Member

lidel commented Apr 15, 2022

This is waiting for go-libp2p 0.19 (to include libp2p/go-libp2p-quic-transport#264 (review))

@dmgk
Copy link

dmgk commented May 6, 2022

go-libp2p currently is at v0.19.1, can this move ahead please?

@aschmahmann
Copy link
Contributor

The version of quic-go is now at 0.27.0 and CI is building with Go 1.18.1.

@chaitanyaprem chaitanyaprem mentioned this issue May 12, 2022
Closed
@mrd0ll4r mrd0ll4r mentioned this issue May 28, 2022
Closed
MrAdityaAlok added a commit to termux/termux-packages that referenced this issue Jun 10, 2022
@MrAdityaAlok
upgpkg(ipfs): update to 0.13.0
8ac9e9e 
- remove workaround for `quick-go` after merger of ipfs/kubo#8819

Signed-off-by: Aditya Alok <dev.aditya.alok@gmail.com>
@smagdali smagdali mentioned this issue Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@lidel @RubenKelevra @marten-seemann @aschmahmann @dmgk @dvergeylen @NatoBoram @makew0rld @RobotSail