Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify where to put default options in option desciption #2744

Merged
merged 1 commit into from
May 21, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented May 19, 2016

Resolves #2702

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu added the need/review Needs a review label May 19, 2016
@RichardLitt
Copy link
Member

Good idea!

@Kubuxu
Copy link
Member Author

Kubuxu commented May 19, 2016

Should I change the tag to <<default>> we are using sometimes things like <date> in the descriptions. I hope there won't be <default> anywhere.

@whyrusleeping
Copy link
Member

This LGTM, good idea :)

@jbenet
Copy link
Member

jbenet commented Aug 26, 2016

Should I change the tag to <<default>> we are using sometimes things like <date> in the descriptions. I hope there won't be <default> anywhere.

@Kubuxu valid concern. I'm not sure-- we may have <default> somewhere. if we don't want it there, we should endeavor to make it obvious to devs somehow. right not it would just silently replace and i may not notice.

@Kubuxu
Copy link
Member Author

Kubuxu commented Aug 26, 2016

I think chaining it to<<default>> has lower cost than writing a document and remembering it. I will follow it up.

@Kubuxu Kubuxu self-assigned this Aug 26, 2016
@Kubuxu Kubuxu removed their assignment Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants