Resolve symlinks of testfiles #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
added
status/in-progress
|
LGTM
I have a Go question though: why `os.Create` instead of `os.Open`?
|
|
Open is read-only. Create is read-write-create, there is also OpenFile allowing for precise control. |
|
@Kubuxu what was the problem here? could I get a tldr? |
|
It was introduced by me in https://travis-ci.org/ipfs/go-ipfs/builds/140867106 as the docker tests were failing already I didn't notice that tests on Travis OS X are failing too. On Travis OS X tmp dir is symlinked causing the test to fail as the path expected did not evaluate symlink. |
|
alright, LGTM |
|
This needs to be reverted too. See #2897 (comment) and #2839 (comment) |
|
Yes, please. |
|
@Kubux @jbenet it looks like @whyrusleeping reverted this in 1aeda7e (part of #2952) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2925
Docker still fails.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch