only pass keys down newBlocks chan in bitswap #3271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
cc @Kubuxu for review |
Kubuxu
reviewed
Sep 29, 2016
| @@ -308,12 +308,17 @@ func (bs *Bitswap) HasBlock(blk blocks.Block) error { | |||
| return err | |||
| } | |||
|
|
|||
| // NOTE: There exists the possiblity for a race condition here. If a user | |||
Kubuxu
reviewed
Sep 29, 2016
| @@ -137,7 +137,7 @@ type Bitswap struct { | |||
|
|
|||
| process process.Process | |||
|
|
|||
| newBlocks chan blocks.Block | |||
| newBlocks chan key.Key | |||
There was a problem hiding this comment.
Maybe rename to newKeys?
but current name also fits.
There was a problem hiding this comment.
Yeah, newBlocks still makes sense to me. I'm going to keep it as is
|
Two comments but generally LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #3262 #3199 and #3246
License: MIT
Signed-off-by: Jeromy why@ipfs.io