-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
random test failure: api not running #3199
Comments
Looks like another of the same: https://s3.amazonaws.com/archive.travis-ci.org/jobs/159382429/log.txt |
Another one: https://travis-ci.org/ipfs/go-ipfs/jobs/159304039 |
This one is happening pretty often on t0400... https://s3.amazonaws.com/archive.travis-ci.org/jobs/159432159/log.txt |
@chriscool is there any way to tel sharness to print out |
@whyrusleeping using This is done for example in test_launch_ipfs_daemon() in test-lib.sh: https://github.com/ipfs/go-ipfs/blob/master/test/sharness/lib/test-lib.sh#L227 |
In https://travis-ci.org/ipfs/go-ipfs/jobs/159304039, the first suspicious thing is:
In https://s3.amazonaws.com/archive.travis-ci.org/jobs/159432159/log.txt there is:
So we can see another instance of "ERROR commands/h: unexpected EOF client.go:247". This corresponds to the following code: https://github.com/ipfs/go-ipfs/blob/master/commands/http/client.go#L247 Maybe the error should be better handled in the go code? |
@chriscool Good catches there... It seems the daemon must be crashing during that add. The unexpected EOF is printed because we werent expecting the http api server to drop our connection suddenly |
@whyrusleeping in the log you just pointed to, there is:
and then there are failures in the following tests. My opinion is that the If the api server drops the connection unexpectedly instead of returning a proper OK, then we should consider that there is an error and we should not exit with code 0. So I think the code in client.go around line 247 is buggy. |
@chriscool oh! good point |
resolved in #3271 |
Saw this one, it happens more frequently than i'd like: https://travis-ci.org/ipfs/go-ipfs/jobs/158756858
Worth noting that i see it across different tests, so its not an issue in the individual tests
The text was updated successfully, but these errors were encountered: