Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pin option for ipfs dag put #4004

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Add pin option for ipfs dag put #4004

merged 1 commit into from
Jul 3, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jun 22, 2017

This at least partially addresses #3544

@Kubuxu Kubuxu added the status/in-progress In progress label Jun 22, 2017
Stebalien
Stebalien approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming the tests pass; it would be nice to get the bots working again...).

@whyrusleeping
Copy link
Member

@magik6k mind rebasing to see if we can get the tests greener?

@magik6k
Add pin option for ipfs dag put
79e21bd 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Copy link
Member Author

magik6k commented Jun 28, 2017

Rebased, tests seem greener.

@whyrusleeping whyrusleeping merged commit 7ad4948 into master Jul 3, 2017
@whyrusleeping whyrusleeping deleted the feat/dagpin branch July 3, 2017 17:54
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jul 3, 2017
@magik6k magik6k mentioned this pull request Jul 27, 2017
Merged
@magik6k magik6k added this to the Ipfs 0.4.11 milestone Aug 13, 2017
@magik6k magik6k restored the feat/dagpin branch November 27, 2017 03:34
@magik6k magik6k deleted the feat/dagpin branch November 27, 2017 03:47
@eingenito eingenito mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ipfs 0.4.11
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @whyrusleeping @Stebalien @Kubuxu