Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block cmd: allow adding multiple blocks at once #6331

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented May 14, 2019

This makes block put consistent with dag put (Addressing #4721)

This will be a minor breaking change for js, cc @vmx

@Stebalien
Copy link
Member

This will be a minor breaking change for js, cc @vmx

cc @alanshaw.

We could also have two cases: 1 return value and multiple return values. However, I'd rather do it this way.

@Stebalien Stebalien requested a review from alanshaw May 14, 2019 22:46
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien
Copy link
Member

This doesn't appear to break interop. Merging.

@Stebalien Stebalien merged commit 07bf2bd into master Jun 4, 2019
@Stebalien Stebalien deleted the feat/block-put-many branch June 4, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants