ignore stale API files and deprecate ipfs repo fsck #6478
Conversation
This command is no longer necessary and is quite dangerous: 1. All lockfiles are now released by the OS when the daemon stops. 2. The API file is ignored when (a) the repo is initialized and (b) daemon is off. fixes #6435
cmd/ipfs/main.go
Outdated
| exctr = cmds.NewExecutor(req.Root) | ||
| // Force the daemon when the API flag is passed (unless we're trying to | ||
| // _run_ the daemon). | ||
| daemonForced := apiAddr != nil && req.Command != daemonCmd |
There was a problem hiding this comment.
pedantic nits:
Force the daemon when the API flag is passed
Should probably be more specific here, forcing the daemon to what?
Initialize temporarily?
daemonForced -> daemonRequested
Despite a user supplying an API addr, commands don't aways force the daemon to do anything.
It's requested, and can be denied if the request is incompatible.
There was a problem hiding this comment.
Thanks, updated. I went back and forth on that several times but decided that e.g., ipfs version should just be run on the client regardless.
There was a problem hiding this comment.
LGTM
Small and optional pedantic comment made in PR.
In the future, (if we can) it may be good to create the API file in the same way we do for the repo lockfile. (have the OS treat it as a temporary file that is removed when the process is no longer running).
But this PR is still necessary for platforms that don't support such a feature, and can contain stale API files.
At this point, we assume that all platforms support it (in practice, all do). The issue is that the daemon may be running on a separate machine. |
ipfs repo fsck(and, if they do, it'll do nothing).This means the following finally works reliably: