Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ipfs repo fsck a no-op. #6435

Closed
Stebalien opened this issue Jun 12, 2019 · 2 comments
Closed

Make ipfs repo fsck a no-op. #6435

Stebalien opened this issue Jun 12, 2019 · 2 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community

Comments

@Stebalien
Copy link
Member

Both the repo and the leveldb datastore use proper file locking on all platforms users should never need to call ipfs repo fsck. Unfortunately, this command can be rather dangerous (#6363).

The only semi-useful thing it does is remove the API file. Any objections to at least gimping this command so it only does that? @magik6k?
@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community labels Jun 12, 2019
@Stebalien Stebalien mentioned this issue Jun 12, 2019
Closed
@djdv
Copy link
Contributor

djdv commented Jun 12, 2019

Chiming in to say that removing lock files isn't the first thing I think of when I think of repo fsck anyway. Typically I assume this to mean some kind of integrity check, and be (more or less) idempotent by default. (At worst setting some kind of "we know it's corrupt"-like flag.)

If the current default behavior deletes without prompt, and can be labeled "dangerous", that seems like it should change.

@Stebalien Stebalien mentioned this issue Jun 14, 2019
Merged
@Stebalien
Copy link
Member Author

So, I'm actually just going to try to go ahead and fix #5784 so we can completely deprecate this command.

Stebalien added a commit that referenced this issue Jun 29, 2019
@Stebalien
feat: deprecate ipfs repo fsck command
a155bf7 
This command is no longer necessary and is quite dangerous:

1. All lockfiles are now released by the OS when the daemon stops.
2. The API file is ignored when (a) the repo is initialized and (b) daemon is
off.

fixes #6435
lanzafame pushed a commit that referenced this issue Jul 30, 2019
@Stebalien @lanzafame
feat: deprecate ipfs repo fsck command
9b59b54 
This command is no longer necessary and is quite dangerous:

1. All lockfiles are now released by the OS when the daemon stops.
2. The API file is ignored when (a) the repo is initialized and (b) daemon is
off.

fixes #6435
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
feat: deprecate ipfs repo fsck command
8559235 
This command is no longer necessary and is quite dangerous:

1. All lockfiles are now released by the OS when the daemon stops.
2. The API file is ignored when (a) the repo is initialized and (b) daemon is
off.

fixes ipfs#6435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @djdv