feat: bootstrap in dht when the routing table is empty #7340
Conversation
| return out, fmt.Errorf("failed to parse bootstrap peer address %q: %s", addrStr, err) | ||
| } | ||
| bootstrappers = append(bootstrappers, addr) | ||
| } |
There was a problem hiding this comment.
Changing dht.BootstrapPeers to take peer.AddrInfo would make this code simpler...
There was a problem hiding this comment.
@Stebalien Have made the change here:
libp2p/go-libp2p-kad-dht#651
Also, we should now use go-libp2p-kad-dht.GetDefaultBootstrapPeerAddrInfos to set the default for cfg. Bootstrap.
There was a problem hiding this comment.
I'm not sure I really understand what makes this easier, but also no complaints from me :)
There was a problem hiding this comment.
It's easier in this case because cfg has a special function to get AddrInfos.
core/node/libp2p/host.go
Outdated
| return out, err | ||
| } | ||
| var bootstrappers []ma.Multiaddr | ||
| for _, addrStr := range cfg.Bootstrap { |
There was a problem hiding this comment.
@Stebalien Is the default for cfg.Bootstrap the DefaultBootstrapPeers value in go-libp2p-kad-dht ?
There was a problem hiding this comment.
Basically, yes. Although I think it's duplicated.
| return out, fmt.Errorf("failed to parse bootstrap peer address %q: %s", addrStr, err) | ||
| } | ||
| bootstrappers = append(bootstrappers, addr) | ||
| } |
There was a problem hiding this comment.
@Stebalien Have made the change here:
libp2p/go-libp2p-kad-dht#651
Also, we should now use go-libp2p-kad-dht.GetDefaultBootstrapPeerAddrInfos to set the default for cfg. Bootstrap.
Stebalien
force-pushed
the
feat/boostrap-when-low
branch
from
25ff976
to
1f21f19
Compare
Otherwise, we could end up with only DHT clients and never re-bootstrap. I've left the default go-ipfs bootstrapping code in for now as it's technically possible to disable the DHT entirely.
Stebalien
force-pushed
the
feat/boostrap-when-low
branch
from
1f21f19
to
ff17485
Compare
Otherwise, we could end up with only DHT clients and never re-bootstrap.
I've left the default go-ipfs bootstrapping code in for now as it's technically possible to disable the DHT entirely.