Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(peering_test) : Fix the peering_test to check the connection explicitly added #8140

Merged
merged 1 commit into from
May 16, 2021

Conversation

TakashiMatsuda
Copy link
Contributor

Overview

This PR is intended to correct the test for peering.PeeringService.

Detail

The current master code tests that h1 is connected to h2 on L69.
I have modified it to check h3.
This test appeared to be intended to test that host.Connect is working correctly after the PeeringService has been started.

Processing flow in the modified area

// h1 is now connected to h2 and h4
h1 -> [h2, h4]
// then explicitly connect to h3 
h1 -> [h2, h4, h3]
// now we want to test is h3
h1 -> h3

Comment

This is the first time I'm commiting to this repository. Please point it out if this PR breaks any conventions.
I've read and respect CONTRIBUTING.md and CONTRIBUTING_GO. Thank you.

This commit fixes the issue that the test of
peering.PeeringService must check the connection of h3
but did not. This line seemed to be unintended.
@welcome
Copy link

welcome bot commented May 15, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Fixing tests is always welcome! Thanks!

@Stebalien Stebalien merged commit 6b9bd6a into ipfs:master May 16, 2021
@TakashiMatsuda TakashiMatsuda deleted the fix/peering_test branch May 17, 2021 00:40
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants