Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to refmt #30

Merged
merged 24 commits into from
Sep 19, 2018
Merged

Refactor to refmt #30

merged 24 commits into from
Sep 19, 2018

Commits on Sep 12, 2018

  1. feat: initial refactor to use refmt

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    9e7d558 View commit details
    Browse the repository at this point in the history

  2. fix copyObj

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e14a4d9 View commit details
    Browse the repository at this point in the history

  3. no more panic todo

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    1d048f4 View commit details
    Browse the repository at this point in the history

  4. golint happy and some fixes

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    3c65d0f View commit details
    Browse the repository at this point in the history

  5. more test cases

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    5106752 View commit details
    Browse the repository at this point in the history

  6. fix examples tests using latest refmt

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    699e7a0 View commit details
    Browse the repository at this point in the history

  7. use standard test script on travis

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    4982e8a View commit details
    Browse the repository at this point in the history

  8. cleanup code

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e506e5e View commit details
    Browse the repository at this point in the history

  9. some cleanup

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    f9b953e View commit details
    Browse the repository at this point in the history

  10. fix json input with cids

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e94e5a0 View commit details
    Browse the repository at this point in the history

  11. tests pass, but requires fix in refmt

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    eab8781 View commit details
    Browse the repository at this point in the history

  12. fix canonical struct encoding

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    fcd1522 View commit details
    Browse the repository at this point in the history

  13. fixes and updates

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    b29b7f4 View commit details
    Browse the repository at this point in the history

  14. update to latest cbor library syntax for sorting

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    573c793 View commit details
    Browse the repository at this point in the history

  15. cleanup errors and comments

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    ff21104 View commit details
    Browse the repository at this point in the history

  16. final import of refmt after fixes upstream

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    666b656 View commit details
    Browse the repository at this point in the history

  17. test: add failing test for nested structs

    @dignifiedquire @Stebalien
    dignifiedquire authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    31243bb View commit details
    Browse the repository at this point in the history

  18. update refmt

    @whyrusleeping @Stebalien
    whyrusleeping authored and Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    782a191 View commit details
    Browse the repository at this point in the history

  19. share a pool of (un)marshallers 

    Also, use a cloner instead of unmarshalling when wrapping an object.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    679ed5f View commit details
    Browse the repository at this point in the history

  20. add a parallel benchmark 

    Increasing `numWorkers` doesn't seem to help at all (not supprising). Really, we
could probably drop to NumCPUs (instad of 2x that) and we'd still be fine.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    cd13b8b View commit details
    Browse the repository at this point in the history

  21. drop to NumCPU + 1 workers 

    More than that doesn't help. +1 helps for the case where a goroutine holding a
worker gets unscheduled.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    ff48bd0 View commit details
    Browse the repository at this point in the history

  22. use a sync.Pool for the refmt (un)marshallers 

    IIRC, pools are cleaned every GC cycle. However, by benchmarks aren't
actually *faster* with this change so I figured we might as well go for it. Our
issue here is really throughput, not latency, so even *if* these pools are
cleaned on GC, it's still useful.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    e5cb584 View commit details
    Browse the repository at this point in the history

  23. replace SetAtlas method with a constructor 

    We don't need to mutate, just replace.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    5896ec2 View commit details
    Browse the repository at this point in the history

  24. fix benchmarks 

    Make sure we *actually* serialize/deserialize. Addresses @warpfork's CR.
    @Stebalien
    Stebalien committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    a1a7802 View commit details
    Browse the repository at this point in the history