feat: store: BatchOpStore (GetMany/PutMany methods)
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBOR GetManyIpldStore
Rebase onto upstream v0.1.0
|
@i-norden are you still working on this set of changes? sorry nobody's been able to review your changes, if these are still in the path of your work we can prioritise them .. just not this week for me sorry but I'll keep it in my queue, it looks quite useful. |
|
Hey @rvagg sorry for abandoning this, we are no longer using this work but if there is still general interest in these changes and/or the linked PRs it is dependent on I can rebase and clean things up this week for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
BatchOpIpldStorethat exposesGetManyandPutManymethods. This is for use in parallelForEachtraversal methods for go-hamt-ipld and go-amt-ipld. Actually only theGetManymethod is being used there, but aPutManymethod was added to compliment it. This PR uses theGetManyblockstore method introduced in ipfs/boxo#492 which, in turn, relies on theTxnDatastorewrappers introduced in ipfs/go-datastore#210.Parallel go-amt-ipld traversal work that uses this: filecoin-project/go-amt-ipld#84
Parallel go-hamt-ipld traversal work that uses this: filecoin-project/go-hamt-ipld#115
TODO:
Replace replace directives if/when dependencies are merged and released