Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored key without a value. {"ignoredError": "json: unsupported type: zap.optionFunc"} #85

Closed
hsanjuan opened this issue May 12, 2020 · 2 comments · Fixed by #86
Closed
Labels
need/triage Needs initial labeling and prioritization

Comments

@hsanjuan
Copy link
Contributor

hsanjuan commented May 12, 2020

DPANIC  crdt    v2@v2.0.7/log.go:44     Ignored key without a value.  {"ignoredError": "json: unsupported type: zap.optionFunc"}

When upgrading to v2.0.7 this happens all over the place in go-ds-crdt tests.

They have a custom logger implementation that wraps this logger: https://github.com/ipfs/go-ds-crdt/blob/master/crdt_test.go#L43

I think the formatting is conflicting with some structured log format that zap is expecting, but I have to look deeper.

Still: The log.go:44 line does not make sense to me, as this would mean the issue is on the logger creation? I am not sure if this means v2.0.7 will break other things, therefore opening this for tracking. If deemed to be go-ds-crdt specific, this can be closed.

@hsanjuan hsanjuan added the need/triage Needs initial labeling and prioritization label May 12, 2020
Stebalien added a commit that referenced this issue May 12, 2020
This time I've actually tested this as best I can (without, you know, adding
actual unit tests).

fixes #85
@Stebalien
Copy link
Member

Because I didn't read the docs and zap isn't doing eager error checking...

@hsanjuan
Copy link
Contributor Author

Thanks 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants