This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Add unsharding logic for the AddChild case as well #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
changed the base branch from
master
to
schomatis/directory/unsharding
schomatis
force-pushed
the
schomatis/directory/unsharding-split/add-unshadring-for-addchild
branch
from
0dbfece
to
a1107a8
Compare
Merged
aschmahmann
changed the base branch from
schomatis/directory/unsharding
to
schomatis/directory/unsharding-split/remove-timeout-refactor
aschmahmann
previously requested changes
Aug 12, 2021
schomatis
commented
Aug 16, 2021
|
I shouldn't have "dismissed" the review, sorry. I didn't know it would delete history. |
schomatis
force-pushed
the
schomatis/directory/unsharding-split/add-unshadring-for-addchild
branch
from
79bf603
to
1fa29a9
Compare
aschmahmann
approved these changes
Aug 25, 2021
Base automatically changed from
schomatis/directory/unsharding-split/remove-timeout-refactor
to
schomatis/directory/unsharding
August 26, 2021 16:32
schomatis
force-pushed
the
schomatis/directory/unsharding-split/add-unshadring-for-addchild
branch
from
1fa29a9
to
7a7204f
Compare
schomatis
force-pushed
the
schomatis/directory/unsharding-split/add-unshadring-for-addchild
branch
from
7a7204f
to
16a96a3
Compare
schomatis
deleted the
schomatis/directory/unsharding-split/add-unshadring-for-addchild
branch
schomatis
added a commit
that referenced
this pull request
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #94 (comment).
Should be reivewed after #102 (on which it's based), the only new commit is a1107a8.
Check for a potential size drop and a HAMT-to-Basic switch even in the add-entry case as it may overwrite an old entry of bigger size.
needsToSwitchToBasicDirto accommodate for both add/remove operations.(UpgradeableDirectory).AddChild().