This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix(dagreader): remove a buggy workaround for a gateway issue #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a hack that "pretended" seeking worked when it didn't as go's HTTP
library uses seeks to determine the file size. However,
1. I'm changing the gateway to actually rely on seeking working as specified.
2. We don't even need this hack. The gateway performs two types of seeks (unless
a range query is passed):
1. It seeks to the beginning. We can always shortcut this.
2. It seeks to the end. The gateway now has a special "lazy" seeker to avoid
seeking until we actually try to _read_. Therefore, we don't need a hack
for that either.
|
This fixes the test failure in ipfs/kubo#6680 (and probably other misc bugs). |
Including the offset.
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 25, 2023
fix(dagreader): remove a buggy workaround for a gateway issue This commit was moved from ipfs/go-unixfs@da35b26
Jorropo
pushed a commit
to ipfs/go-libipfs-rapide
that referenced
this pull request
Mar 23, 2023
fix(dagreader): remove a buggy workaround for a gateway issue This commit was moved from ipfs/go-unixfs@da35b26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a hack that "pretended" seeking worked when it didn't as go's HTTP
library uses seeks to determine the file size. However,
a range query is passed):
seeking until we actually try to read. Therefore, we don't need a hack
for that either.