Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump v1.7.0 #48

Merged
merged 2 commits into from
May 17, 2023
Merged

bump v1.7.0 #48

merged 2 commits into from
May 17, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 17, 2023

semver-minor for added test utilities

@github-actions
Copy link

Suggested version: v1.7.0

Comparing to: v1.6.0 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

gorelease: preparing to load packages for github.com/ipfs/go-unixfsnode: looking for missing dependencies: go: downloading github.com/ipfs/go-unixfsnode v1.5.2
go: downloading github.com/ipfs/go-unixfsnode v1.6.0
gorelease-load-module imports
	github.com/ipfs/go-unixfsnode/testutil: cannot find module providing package github.com/ipfs/go-unixfsnode/testutil
gorelease-load-module imports
	github.com/ipfs/go-unixfsnode/testutil/namegen: cannot find module providing package github.com/ipfs/go-unixfsnode/testutil/namegen

gocompat says:

Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@rvagg
Copy link
Member Author

rvagg commented May 17, 2023

I'm not exactly sure what gorelease is complaining about. I think it's making a fake package and importing everything then running a go get and seeing what complains. So I believe the output above is just saying "hey, new packages", strange that it's not doing it in a way that gives a less hostile looking error message.

https://go.googlesource.com/exp/+/master/cmd/gorelease/gorelease.go#1110

@masih @willscott any thoughts on whether there's a problem here? (background: they're new packages #47)

@willscott
Copy link
Collaborator

I'd probably push through with it and see if the release work?

@masih
Copy link
Member

masih commented May 17, 2023

I agree with @willscott; changes here seem fine to me 👍

@rvagg rvagg merged commit 852acf4 into main May 17, 2023
19 checks passed
@rvagg rvagg deleted the rvagg/v1.7.0 branch May 17, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants