fix: check eviction filter for new providers (#542)

When new providers are found, check the eviction filter in `isEvicted`
rather than the current list of providers.

Fixes #501

packages/utils/src/abstract-session.ts

@@ -188,7 +188,7 @@ export abstract class AbstractSession<Provider, RetrieveBlockProgressEvents exte
   }
 
   isEvicted (provider: Provider): boolean {
-    return this.providers.some(prov => this.equals(prov, provider))
+    return this.evictionFilter.has(this.toEvictionKey(provider))
   }
 
   hasProvider (provider: Provider): boolean {

packages/utils/test/abstract-session.spec.ts

@@ -233,4 +233,25 @@ describe('abstract-session', () => {
     })).to.eventually.be.rejected()
       .with.property('code', 'ABORT_ERR')
   })
+
+  it('should not make multiple requests to the only found provider', async function () {
+    const session = new Session()
+    const cid = CID.parse('bafybeifaymukvfkyw6xgh4th7tsctiifr4ea2btoznf46y6b2fnvikdczi')
+    const id = await createEd25519PeerId() // same provider
+
+    session.findNewProviders.callsFake(async function * () {
+      yield {
+        id
+      }
+    })
+    session.queryProvider.callsFake(async () => {
+      // always fails
+      throw new Error('Urk!')
+    })
+
+    await expect(session.retrieve(cid)).to.eventually.be.rejected()
+
+    expect(session.findNewProviders).to.have.property('callCount', 2)
+    expect(session.queryProvider).to.have.property('callCount', 1)
+  })
 })