fix: http blockbroker loads gateways from routing #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new http gateway block broker to load gateways from the routing. If we can find http gateways for a block we now use it, falling back to the default list of gateways if the routing is slow or it gives providers that fail to supply the block.
SgtPooki
approved these changes
Apr 25, 2024
Comment on lines
15
to
16
| // 2023-10-03: IPNS, Origin, and Block/CAR support from https://ipfs-public-gateway-checker.on.fleek.co/ | ||
| 'https://cloudflare-ipfs.com', |
There was a problem hiding this comment.
we might want to remove this one?
There was a problem hiding this comment.
It does appear to be down. As does https://ipfs-public-gateway-checker.on.fleek.co
Le sigh.
achingbrain
commented
Apr 25, 2024
SgtPooki
approved these changes
Apr 25, 2024
achingbrain
deleted the
fix/gateway-block-broker-load-gateways-from-routing
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new http gateway block broker to load gateways from the routing.
If we can find http gateways for a block we now use it, falling back to the default list of gateways if the routing is slow or it gives providers that fail to supply the block.
One change here is that unless you are using sessions, trustless gateways become disposable so we can't sort them by reliability any more.
I'm not sure if we have any stats on the real-world impact of being able to do this? It may be more relevant for sessions anyway, I think.
Change checklist