Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Interop tests are broken in go-ipfs #100

Closed
Stebalien opened this issue Feb 10, 2020 · 2 comments · Fixed by ipfs/kubo#6899
Closed

Interop tests are broken in go-ipfs #100

Stebalien opened this issue Feb 10, 2020 · 2 comments · Fixed by ipfs/kubo#6899
Assignees

Comments

@Stebalien
Copy link
Member

The interop tests have been failing in go-ipfs master for a while and nothing there has changed, as far as I know. Could someone look into this (@achingbrain)?

Ex: https://app.circleci.com/jobs/github/ipfs/go-ipfs/24305

@achingbrain
Copy link
Member

achingbrain commented Feb 13, 2020

I think this is because peerIDs used to be an instance of peer-id but now they are strings (so as to not require bundling libp2p-crypto with the http client, shaving a few hundred KBs off the bundle size) - this should be fixed in master now.

For that build you'll need to remove the Installing js-ipfs step as js-ipfs and js-ipfs-http-client are now included in the interop module as dev dependencies.

Stebalien added a commit to ipfs/kubo that referenced this issue Feb 13, 2020
Stebalien added a commit to ipfs/kubo that referenced this issue Feb 13, 2020
@Stebalien
Copy link
Member Author

ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants