This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
fix: pubsub tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
approved these changes
May 9, 2019
|
LGTM, windows failure is persistent though. Looks vaguely unrelated but |
|
@alanshaw it looks like this is a flakey timeout issue. I reran windows and it passed this time. I think I've seen the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into
pull-mplexupdates in js-ipfs I noticed the pubsub tests here needed improvement. For example, JS -> JS and go -> go just use the same node for publishing and subscribing. I refactored the tests to spin up unique nodes for each suite.This exposed a current issue with go -> js pubsub failing. I am looking into this.