fix: empty streams #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 94.73% 94.49% -0.25%
==========================================
Files 3 3
Lines 114 109 -5
==========================================
- Hits 108 103 -5
Misses 6 6
Continue to review full report at Codecov.
|
alanshaw
suggested changes
May 1, 2019
| ).to.be.eql([ | ||
| Buffer.alloc(0), | ||
| Buffer.from('more data') | ||
| ]) |
There was a problem hiding this comment.
This makes sense, we should be able to pull an empty buffer.
|
@alanshaw i've updated the code and tests to better match expected pull-stream behavior |
dignifiedquire
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update to better support empty streams was ending streams when an empty value was decoded, it shouldn't, as this prevents other values from being returned. A receiver may respond with an empty message and then continue to write subsequent responses on the same stream.