Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable ssr #40

Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix: enable ssr #40

merged 2 commits into from
Jan 28, 2021

Conversation

jdiogopeixoto
Copy link
Contributor

@jdiogopeixoto jdiogopeixoto commented Jan 27, 2021 •
edited
Loading

This PR:

Preview: https://deploy-preview-40--ipfs-blog.netlify.app

Closes #30

@jdiogopeixoto jdiogopeixoto self-assigned this Jan 27, 2021
@jessicaschilling jessicaschilling removed their request for review January 27, 2021 15:58
@jessicaschilling
Copy link
Contributor

I'm going to remove myself as a reviewer since this is @cwaring's wheelhouse - Chris, can you please review at your earliest convenience? Thank you.

@cwaring cwaring mentioned this pull request Jan 27, 2021
Closed
cwaring
cwaring approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@cwaring cwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the SRR issue however there are still some very big performance problems. I've captured the details in #41 to help you investigate further.

@jdiogopeixoto jdiogopeixoto merged commit b4232d1 into main Jan 28, 2021
@jdiogopeixoto jdiogopeixoto deleted the fix/index-ssr branch January 28, 2021 14:58
@jessicaschilling jessicaschilling added this to Review/QA in IPFS Website/Blog/Ecosystem Directory via automation Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwaring cwaring cwaring approved these changes

Assignees

@jdiogopeixoto jdiogopeixoto

Labels
None yet
Projects
IPFS Website/Blog/Ecosystem Directory
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ensure SSR is enabled for the index page
3 participants
@jdiogopeixoto @jessicaschilling @cwaring