Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken UI in Incognito #243

Closed
lidel opened this issue May 2, 2017 · 0 comments
Closed

Fix broken UI in Incognito #243

lidel opened this issue May 2, 2017 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented May 2, 2017 •
edited
Loading

If browserAction was clicked in incognito window, browser.runtime.getBackgroundPage() returns null and GUI breaks (under Firefox).

We should detect incognito context and fix/hide broken UI elements.

Ref. https://discourse.mozilla-community.org/t/getbackgroundpage-in-private-mode/14046/6?u=lidel
@lidel lidel added kind/bug A bug in existing code (including security flaws) UX labels May 2, 2017
This was referenced Jul 8, 2017
Closed
Merged
@lidel lidel closed this as completed in a10ce15 Jul 9, 2017
lidel added a commit that referenced this issue Jun 15, 2018
@lidel
fix: hide unavailable actions in incognito mode
29d7bb1 
This commit solves some regressions related to background page access
being denied in incognito mode.

More context:
#477
#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel