Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify rendering issue #539

Closed
djdv opened this issue Jul 24, 2018 · 3 comments
Closed

Linkify rendering issue #539

djdv opened this issue Jul 24, 2018 · 3 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@djdv
Copy link

djdv commented Jul 24, 2018

I'm currently on the beta version 2.4.2.10500 (9424acc)

Partial hashes seem to render incorrectly. I noticed the body of one of my emails looked wrong with this string

file {
data: ...
metadata: /ipfs/Qm... | /ipns/Qm...
}

it's rendering like this in Gmail

2

and as
untitled

when viewed as a txt file

@lidel lidel added kind/bug A bug in existing code (including security flaws) UX labels Jul 24, 2018
@lidel
Copy link
Member

lidel commented Jul 24, 2018

Ack, this is a side effect of Linkify – our fun and invasive experiment that mutates DOM 🙃

[note to self] fix for this:
a) linkify should just ignore <pre> blocks (high now we only ignore styled ones, but it is not enough)
b) linkify should not run on if content-type is text/plain (sample)
c) linkify should not wrap false-positives in a <span> – we already cache IPFS validation in a map per page, so its safe to do it every time DOM chunk with false-positive is mutated

@Stebalien
Copy link
Member

Similar issue: "ipfs cat /pfs/QmId" renders as "/ipfs/QmId". Example:

ipfs cat /ipfs/QmId

(note: "ipfs cat /pfs/QmId" renders fine because my i isn't actually an i 😈 ).

@lidel
Copy link
Member

lidel commented Aug 1, 2018

FYI the fix landed in v2.4.4. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants