Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning does not support uri "hash" parameter #567

Closed
hazae41 opened this issue Sep 9, 2018 · 1 comment
Closed

Pinning does not support uri "hash" parameter #567

hazae41 opened this issue Sep 9, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@hazae41
Copy link

hazae41 commented Sep 9, 2018

When trying to pin an url like
http://ipfs.io/ipfs/Qm.../#download
It says that "#download" does not belong to "Qm..."
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Sep 9, 2018
lidel added a commit that referenced this issue Sep 9, 2018
@lidel
fix: pin URL with hash or query
32c1b55 
Closes: #567
@lidel lidel mentioned this issue Sep 9, 2018
Merged
@lidel
Copy link
Member

lidel commented Sep 9, 2018

Thank you for reporting this! I fixed this (and ?foo) in #568.

lidel added a commit that referenced this issue Sep 13, 2018
@lidel
fix: pin URL with hash or query
86760a5 
Closes: #567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @hazae41