Brave: regression in embedded /api/v0/add #757
Labels
area/brave
Issues related to Brave Browser
kind/bug
A bug in existing code (including security flaws)
Projects
Context
Embedded js-ipfs in Brave is using
chrome-net
,http-node
,iso-url
and some other tricks to convince@hapi/hapi
HTTP server that it is running in Node.js 馃槵ipfs/js-ipfs#2379 switched
ipfs.add
toipfs._addAsyncIterator
and it introduced regression in/api/v0/add
HTTP API endpoint exposed by embedded js-ipfs in Brave.Provisional fix
It seems old polyfills are no longer enough. Real fix requires more time to investigate, so for now we switched (2728436) to version of js-ipfs before ipfs/js-ipfs#2379.
How to reproduce
The problem is present only in HTTP API exposed by js-ipfs embedded in ipfs-companion running in Brave.
/api/v0/add
before ipfs/js-ipfs#2379 works fine:/api/v0/add
after ipfs/js-ipfs#2379 is missing response body in Brave:However, the same code (
/api/v0/add
after ipfs/js-ipfs#2379) running asjsipfs daemon
works fine!:The text was updated successfully, but these errors were encountered: