Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update standard to the latest version 馃殌 #198

Merged
merged 3 commits into from
Feb 11, 2017
Merged

Update standard to the latest version 馃殌 #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d111ad
chore(package): update standard to version 9.0.0-beta.0
greenkeeper[bot] Feb 9, 2017
b049695
fix(standard): comply with new rules introduces by 9.x
lidel Feb 11, 2017
68d950d
Merge branch 'master' into greenkeeper/standard-9.0.0-beta.0
lidel Feb 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion add-on/src/background/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@

// init add-on after all libs are loaded
document.addEventListener('DOMContentLoaded', init)

10 changes: 2 additions & 8 deletions add-on/src/lib/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,17 +174,11 @@ function readDnslinkTxtRecordFromApi (fqdn) {
// TODO: find/fill an upstream bug to make this more intuitive
resolve(false)
} else {
reject({
status: this.status,
statusText: xhr.statusText
})
reject(new Error(xhr.statusText))
}
}
xhr.onerror = function () {
reject({
status: this.status,
statusText: xhr.statusText
})
reject(new Error(xhr.statusText))
}
xhr.send()
})
Expand Down
1 change: 0 additions & 1 deletion add-on/src/options/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,3 @@ document.addEventListener('DOMContentLoaded', readAllOptions)

// update on external changes such as browserAction menu
browser.storage.onChanged.addListener(readAllOptions)

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"sinon": "1.17.7",
"sinon-chai": "2.8.0",
"sinon-chrome": "2.1.2",
"standard": "8.6.0",
"standard": "9.0.0-beta.0",
"web-ext": "1.8.1"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions test/unit/browser.shim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict'
/* eslint-env browser, webextensions */
/* eslint no-use-before-define: 0 */

// without this shim unit tests fail -- sinon-chrome does not stub browser yet
var browser = browser || chrome