Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser Action popup fixes #354

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Browser Action popup fixes #354

merged 2 commits into from
Jan 9, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Jan 7, 2018 •
edited
Loading

  • closes Error while removing IPFS Pin #338
  • as a side-effect this PR may improve situation with Popup render issue in Chrome #318
    • I tested in Chrome under Linux and popup never breaks
    • would be great if someone checked under macOS, as we suspect it to be platform-specific
  • it should not break anything under Brave, but l'd sleep better if someone confirmed it works there too – would appreciate a quick smoke-test :-)

@lidel
fix: notification error on pin/unpin
6081df0 
- closes #338
- as a side-effect may improve situation with #318
@lidel lidel added the UX label Jan 7, 2018
@lidel lidel self-assigned this Jan 7, 2018
@olizilla
Copy link
Member

olizilla commented Jan 9, 2018

👀

@olizilla
Copy link
Member

olizilla commented Jan 9, 2018

Brave: ✅

@olizilla
Copy link
Member

olizilla commented Jan 9, 2018

With some ruthless clicking I still able to get chrome to do the jank render

screenshot 2018-01-09 14 34 09

and I'm kinda proud of this one

screenshot 2018-01-09 14 33 44

but otherwise, all was well. Firefox rendered all smooth and nice no matter how much I clicked and pin/unpin works without error in all.

@lidel lidel merged commit 3826d36 into master Jan 9, 2018
@lidel lidel deleted the fix-pin-error branch January 9, 2018 23:37
@lidel
Copy link
Member Author

lidel commented Jan 9, 2018

Thanks @olizilla, let's keep #318 open then :)

ps. the last one was glorious!

@lidel lidel mentioned this pull request Jan 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while removing IPFS Pin
2 participants
@lidel @olizilla