Fix popup render issue in Chrome on Mac #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://bugs.chromium.org/p/chromium/issues/detail?id=428044#c13 Hopefully closes #318
|
@lidel we didn't need that extra render so I removed. I also simplified the code a little and shortened the timeouts. Looks like the animation in takes 150ms so as long as we set a height on the body before that ends and remove it afterwards then we're good. I found that the popup "jumped around" a bit less with the shorter timeout (but still appeared correctly eventually). Hope that's ok! |
|
👍 lets merge it and do RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebased version of #355, hopefully closes #318
I do not own a Mac, so re-assigning to @olizilla who noticed it in #318 (comment)