Upload screen feedback and bugfixes #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- display visual feedback for ongoing upload (realtime if possible) - use streaming to solve a set of errors caused by big files and js-ipfs
More context: #464
lidel
changed the title
olizilla
reviewed
May 23, 2018
add-on/src/popup/quick-upload.js
Outdated
| pin: state.pinUpload | ||
| } | ||
| console.log('Calling background.ipfsAddAndShow', files) |
olizilla
reviewed
May 23, 2018
add-on/src/popup/quick-upload.js
Outdated
| @@ -141,7 +181,7 @@ function quickUploadPage (state, emit) { | |||
| </emph> | |||
| ${browser.i18n.getMessage('quickUpload_drop_it_here')} | |||
| </span> | |||
| <p class='f4'>${state.message}</p> | |||
| <p class='f4 db relative'>${state.message}<span class='code db absolute fr pv2'>${state.progress}</span></p> | |||
There was a problem hiding this comment.
I don't think we need absolute / relative position dancing here.
olizilla
reviewed
May 23, 2018
package.json
Outdated
| @@ -90,9 +90,11 @@ | |||
| "web-ext": "2.6.0" | |||
| }, | |||
| "dependencies": { | |||
| "byte-size": "4.0.3", | |||
There was a problem hiding this comment.
we're using filesize in ipld-cli and share-via-ips and webui
https://www.npmjs.com/package/filesize
There was a problem hiding this comment.
@olizilla I was unable to set up filesize in a way that keeps static number of decimal digits 🙃
So I just dropped them, to keep things simple:
As suggested in #483 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Fixes
Future Improvements
Preview
when js-ipfs is used, progress is provided in realtime (js-ipfs-api displays buffering state for the most of time):
Useful commands
Creating a sparse file (filled with zeroes) of arbitrary size:
Big files filled with zeroes are handy for tests with js-ipfs, which has a limited repo store size (one chunk will just be reused).