osx: quiting app does not always kill ipfs #12
Comments
|
another note, if the electron-app crashes (or is force quit) it doesnt also bring down the |
|
this is now addressed in node-ipfsd-ctl, except maybe the crash issue. i'll investigate |
|
Referenced here: #25 (comment) |
hacdias
added a commit
that referenced
this issue
Aug 29, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
that referenced
this issue
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
that referenced
this issue
Sep 2, 2019
# This is the 1st commit message: try gh actions License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #2: add build License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #3: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #4: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #5: add gh token License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #6: fix names License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #7: add chrome-log driver License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #8: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #9: xvfb? License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #10: install xvfb License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #11: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #12: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #13: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #14: add screensize License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #15: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #16: License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #17: xvfb-maybe License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com> # This is the commit message #18: chore! License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
go-ipfs is notoriously annoying to kill, because it tries to shut down gracefully first.
electron-appornode-ipfsd-ctrlshould make sure ipfs is killed by waiting + checking.The text was updated successfully, but these errors were encountered: