Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable/enable gc via settings menu #1740

Merged
merged 2 commits into from Jan 25, 2021

Conversation

andrew
Copy link
Contributor

@andrew andrew commented Jan 20, 2021

Closes #1647 (now that #1735 has been merged)

Very similar approach to #1735

Screenshot 2021-01-20 at 16 21 01

@jessicaschilling
Copy link
Contributor

@lidel, for your review 😊

- setting default state to on for new and pre-existing config
- remove keysize (not needed since go-ipfs 0.7.0 uses ED25519 keys by
  default)

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrew!

Made small tweaks:

  • added migration setting default state to active for new and pre-existing config
  • removed keysize (not needed since go-ipfs 0.7.0 uses ED25519 keys by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu items for enabling pubsub and automatic GC
3 participants