Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: click on notification after import of files #1853

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 23, 2021

This PR aims to fix UX issue and close #1815, but is bit tricky for me personally as I don't own any Windows box.
Need to figure out how to test this.

Test case

  1. Install IPFS Desktop
  2. Right click on a file and "Add to IPFS"
  3. Click on the popup displayed by windows

Expected behavior is that Files screen will be opened.

TODO

  • fix the bug on Windows ;-)
  • install .exe created by CI and confirm test case above passes

@lidel lidel added the area/windows Windows label Jun 24, 2021
@lidel lidel changed the title wip: focus window before navigating fix: open Files after clicking on "add to IPFS" notification on Windows Jun 24, 2021
@lidel lidel marked this pull request as ready for review June 24, 2021 08:38
@lidel lidel force-pushed the fix/add-to-ipfs-windows branch 5 times, most recently from 92c6eaf to a75d3ee Compare June 24, 2021 12:08
this aims to fix issue from
#1815
@lidel lidel changed the title fix: open Files after clicking on "add to IPFS" notification on Windows fix: click on notification after import of files Jun 24, 2021
@lidel
Copy link
Member Author

lidel commented Jun 24, 2021

@RubenKelevra I believe this should fix the issue you reported in #1858 – mind taking https://bafybeia5lt47ozlqw7skx5vje4v7rrnllwb2j4ephg3i6tlhcig624etce.ipfs.dweb.link/IPFS%20Desktop%20Setup%200.16.0.exe (0.16.0 + patch from this PR) for a spin and confirm the issue is gone?

@RubenKelevra
Copy link
Contributor

@RubenKelevra I believe this should fix the issue you reported in #1858 – mind taking https://bafybeia5lt47ozlqw7skx5vje4v7rrnllwb2j4ephg3i6tlhcig624etce.ipfs.dweb.link/IPFS%20Desktop%20Setup%200.16.0.exe (0.16.0 + patch from this PR) for a spin and confirm the issue is gone?

Yeah sure. Will do that and report back :)

I usually don't use windows as well, just got a new device and tried ipfs on it :)

@RubenKelevra
Copy link
Contributor

@lidel works for me :)

ipfs_desktop_screenshot_bugreport_imported_files_click_on_notification_fix

@RubenKelevra
Copy link
Contributor

Expected behavior is that Files screen will be opened.

Well, not exactly. the file itself will be opened, not the "files screen".

@lidel lidel merged commit 22d189c into main Jul 5, 2021
@lidel lidel deleted the fix/add-to-ipfs-windows branch July 5, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add to IPFS" on Windows does not open correct Files path
2 participants