fix: analytics storage_path in $HOME/.ipfs-desktop #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
requested changes
Sep 6, 2021
There was a problem hiding this comment.
Makes sense, this will remove noisy error (example below) printed to the cli when using .tar.xz package (and most likely others):
$ ./ipfs-desktop
2021-09-07T19:24:25.963Z info: [meta] logs can be found on /home/lidel/.config/IPFS Desktop
Error: ENOTDIR: not a directory, mkdir '/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/node_modules/countly-sdk-nodejs/data'
at Object.mkdirSync (fs.js:987:3)
at Object.Countly.init (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:157:24)
at module.exports (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/src/analytics.js:6:11)
at run (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/src/index.js:68:11)
Error: ENOENT, node_modules/countly-sdk-nodejs/data/__cly_id.json not found in /home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar
at createError (electron/js2c/asar_bundle.js:5:1289)
at Object.t.<computed> [as open] (electron/js2c/asar_bundle.js:5:2560)
at Object.writeFile (fs.js:1446:6)
at writeFile (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1540:12)
at storeSet (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:1570:13)
at Object.Countly.init (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/node_modules/countly-sdk-nodejs/lib/countly.js:173:21)
at module.exports (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/src/analytics.js:6:11)
at run (/home/lidel/tmp/ipfs-desktop-0.16.3-rc1/ipfs-desktop-0.16.3-linux-x64/resources/app.asar/src/index.js:68:11) {
code: 'ENOENT',
errno: -2
}Before we merge this, small asks inline.
lidel
added
need/author-input
userData The directory for storing your app's configuration files, which by default it is the appData directory appended with your app's name. https://github.com/electron/electron/blob/main/docs/api/app.md#appgetpathname
lidel
force-pushed
the
fix-analytics-storage-path
branch
from
ee5fa81
to
c6dd22b
Compare
lidel
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Rebased and switched to userData
This means analytics data will land in dirs as described in https://github.com/electron/electron/blob/main/docs/api/app.md#appgetpathname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it work with a read-only node_modules