fix: i18n init done fires even with lang load error #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18next has some auto-magical loading of translation files that kicks off loading multiple languages (e.g. 'en', 'en-US', 'en-UK', etc.) but we don't have all of those files for IPFS-Desktop. i18next.init will fire an error if any of those files fail to load, even if one succeeds. This fix ensures that `i18n.initDone` is set on context even if we see an error. fixes #2627
SgtPooki
changed the title
SgtPooki
commented
Oct 5, 2023
Comment on lines
+40
to
+41
| logger.error('[i18n] init error') | ||
| logger.error(err) |
There was a problem hiding this comment.
the actual Error was not being logged for some reason... error files and logging patterns need a serious look
whizzzkid
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18next has some auto-magical loading of translation files that kicks
off loading multiple languages (e.g. 'en', 'en-US', 'en-UK', etc.) but
we don't have all of those files for IPFS-Desktop. i18next.init
will fire an error if any of those files fail to load, even if one
succeeds.
This fix ensures that
i18n.initDoneis set on context even if we seean error.
fixes #2627