Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ipfs-desktop config can disable autoUpdate #2651

Merged
merged 5 commits into from Oct 10, 2023
Merged

fix: ipfs-desktop config can disable autoUpdate #2651

merged 5 commits into from Oct 10, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 5, 2023

see #2613 (comment) for more details

fixes #2613

@SgtPooki SgtPooki requested review from whizzzkid and a team as code owners October 5, 2023 00:59
@SgtPooki SgtPooki linked an issue Oct 5, 2023 that may be closed by this pull request
How i can block IPFS Update? #2613
Closed
whizzzkid
whizzzkid approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this is fragmentation, more people across more versions. Harder to support!

But if you feel this is good to have, go for it.

@SgtPooki
Copy link
Member Author

SgtPooki commented Oct 5, 2023 •
edited

I talked to lidel about it. I mean, our first fix suggestion is to upgrade to latest.. So if people do turn off autoUpdate we wont be able to do much.

But thats also why I dont want a UI option for it

lidel
lidel requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it should be a flag that controls disabling, not enabling – see comment inline

src/auto-updater/index.js Outdated Show resolved Hide resolved
src/common/config-keys.js Outdated Show resolved Hide resolved
lidel
lidel approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(that is to say, ok to ship once feedback above addressed)

@SgtPooki SgtPooki merged commit 5cb5fa3 into main Oct 10, 2023
7 checks passed
@SgtPooki SgtPooki deleted the 2613-how-i-can-block-ipfs-update branch October 10, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@whizzzkid whizzzkid whizzzkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How i can block IPFS Update?
3 participants
@SgtPooki @lidel @whizzzkid